Skip to content

FST: Extend FST to allow for ITS-GPU reco#14106

Merged
mconcas merged 2 commits intoAliceO2Group:devfrom
mconcas:pr_itsgpu_fst
Mar 31, 2025
Merged

FST: Extend FST to allow for ITS-GPU reco#14106
mconcas merged 2 commits intoAliceO2Group:devfrom
mconcas:pr_itsgpu_fst

Conversation

@mconcas
Copy link
Collaborator

@mconcas mconcas commented Mar 25, 2025 •
edited
Loading

Before merging:

  • Fix funny behaviour not finding clusters in FST scripts but works in manual gpu-reco-workflow invocation
  • Uncompress the clusters
  • Write ITS tracks

Requires: AliceO2Group/O2DPG#1951

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

davidrohr
davidrohr requested changes Mar 25, 2025
View reviewed changes
prodtests/full-system-test/dpl-workflow.sh Outdated
if [[ ! -z $INPUT_DETECTOR_LIST ]]; then
if [[ $CTFINPUT == 1 ]]; then
GPU_INPUT=compressed-clusters-ctf
has_detectors_gpu TPC ITS && GPU_INPUT+=",its-clusters"
Copy link
Collaborator

@davidrohr davidrohr Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you do this only for CTFINPUT=1, I think this should be global?
Simiar for the GPU_OUTPUT above. In principle, I'd set the ITS input and outputs in GPU_INPUT and GPU_OUTPUT at the same place to avoid confusion.

@mconcas mconcas force-pushed the pr_itsgpu_fst branch 2 times, most recently from 4213c3a to 011d361 Compare March 27, 2025 07:36
davidrohr
davidrohr reviewed Mar 27, 2025
View reviewed changes
davidrohr
davidrohr previously approved these changes Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@davidrohr davidrohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good now 👍
Let me know when it is working :).

@mconcas
Copy link
Collaborator Author

mconcas commented Mar 27, 2025 •
edited
Loading

Otherwise looks good now 👍 Let me know when it is working :).

Ok, I connected also the writer, now it should be functional. Tested in PbPb with:

#! /bin/bash -x

rm -f /dev/shm/*fmq*;
# export DISABLE_ROOT_OUTPUT=0
export GPUTYPE=CUDA
export WORKFLOW_DETECTORS=TPC,ITS
export WORKFLOW_DETECTORS_GPU=ITS,TPC
export GPUMEMSIZE=10000000000
export SYNCMODE=0
export CTFINPUT=1
export GLOBALDPLOPT="-b"
export NTIMEFRAMES=1
export INPUT_FILE_LIST=data/o2_ctf_run00559456_orbit0139181824_tf0003905868_epn294.root
export CONFIG_EXTRA_PROCESS_o2_gpu_reco_workflow="GPU_proc.debugLevel=2;GPU_global.deviceType=$GPUTYPE;GPU_proc.forceMemoryPoolSize=8000000000;GPU_proc.forceHostMemoryPoolSize=1073741824;"
~/alice/latest/O2/prodtests/full-system-test/dpl-workflow.sh

@mconcas mconcas marked this pull request as ready for review March 27, 2025 07:50
@mconcas mconcas requested a review from a team as a code owner March 27, 2025 07:50
mconcas
mconcas commented Mar 27, 2025
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Mar 27, 2025 •
edited
Loading

Error while checking build/O2/fullCI_slc9 for 22e3089 at 2025-03-27 19:16:

## sw/BUILD/ONNXRuntime-latest/log
CMake Error at /sw/slc9_x86-64/CMake/v3.31.6-1/share/cmake-3.31/Modules/FindProtobuf.cmake:613 (file):
CMake Error at /sw/slc9_x86-64/CMake/v3.31.6-1/share/cmake-3.31/Modules/FindProtobuf.cmake:619 (math):
CMake Error at /sw/slc9_x86-64/CMake/v3.31.6-1/share/cmake-3.31/Modules/FindProtobuf.cmake:620 (math):
CMake Error at /sw/slc9_x86-64/CMake/v3.31.6-1/share/cmake-3.31/Modules/FindProtobuf.cmake:621 (math):

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Mar 28, 2025

Error while checking build/O2/fullCI_slc9 for 0670706 at 2025-03-28 20:24:

## sw/BUILD/O2-latest/log
CMake Error at cmake/O2RootMacroExclusionList.cmake:87 (message):

Full log here.

@mconcas mconcas merged commit 1102011 into AliceO2Group:dev Mar 31, 2025
11 checks passed
@mconcas mconcas deleted the pr_itsgpu_fst branch March 31, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidrohr davidrohr davidrohr left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mconcas @alibuild @davidrohr